Skip to content

Add error message/handling for case in which there is no app on Gallery.#255

Merged
shammamah-zz merged 2 commits intomasterfrom
gallery-app-error-handling
Jul 30, 2019
Merged

Add error message/handling for case in which there is no app on Gallery.#255
shammamah-zz merged 2 commits intomasterfrom
gallery-app-error-handling

Conversation

@shammamah-zz
Copy link
Copy Markdown
Contributor

@shammamah-zz shammamah-zz commented Jul 29, 2019

This PR proposes to display a helpful error message whenever an app exists in the repository but has not been declared in Dash Enterprise's app manager, or when the entry has been removed prior to redeployment.

Comment thread .circleci/config.yml Outdated
Copy link
Copy Markdown
Contributor

@chriskfwoo chriskfwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💃

@rpkyle
Copy link
Copy Markdown
Contributor

rpkyle commented Jul 30, 2019

Looks 👌 to me as well! 💃

@shammamah-zz shammamah-zz merged commit 0caa46f into master Jul 30, 2019
@shammamah-zz shammamah-zz deleted the gallery-app-error-handling branch July 30, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants